Feat(CLI): Infra manifest support default modules #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrzn
requested review from
dOrgJelli,
krisbitney,
namesty and
nerfZael
as code owners
dOrgJelli
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add the capability to add a default module in the manifest, this means that we can do:
And it will load both modules
edit: When developing this feature, I noticed that it was not possible to declare a file (i.e:
my_folder/docker.compose.yaml) as a value forpathin local modules, I found this weird, so I went ahead and add support to add files or folder, this way is more friendly to interact with infra :-Dso basically now this is supported: